search

JasonMillward / Autorippr

Rip discs automatically using a blend of Python, MakeMKV and HandBrake
MIT License
241 stars 60 forks source link

Append titleId for multi-title discs #78

Closed ascendedguard closed 9 years ago

ascendedguard commented 9 years ago

Fixes issues with Handbrake overwriting files and only a single title remaining after encoding completes.

However, I made schema changes to the database, and this required me deleting the existing autorippr.sqlite database for it to run. I'm currently saving the titleId and whether the disc was multi-title, meaning multiple titles would have normally overwritten.

I'm now sure if you a) want to delete the existing sqlite database automatically somehow, or b) change this to not need the info stored in the database.

I've tested this with 2 movies so far, a single title and multi-title, and it works fine with both.

Inception (multi title) ended up with the appropriate files:

Inception-0.mkv
Inception-1.mkv

And The Hobbit (single title) did as well:

Hobbit Part1.mkv
JasonMillward commented 9 years ago

Looks good. I'll double check everything over the weekend and merge it in.

ascendedguard commented 9 years ago

I didn't test how this affects TV show support (since I don't have any to rip). Otherwise this should close #75 - Adding an option to limit to a single title turned out to not help since I couldn't find a way to determine which is the main title.

JasonMillward commented 9 years ago

Works well on TV show discs. 

Breaking Bad Final D1-0.mkv
Breaking Bad Final D1-1.mkv
Breaking Bad Final D1-2.mkv
Breaking Bad Final D1-3.mkv
Breaking Bad Final D1-4.mkv
Breaking Bad Final D1-5.mkv