search

JasonMillward / Autorippr

Rip discs automatically using a blend of Python, MakeMKV and HandBrake
MIT License
241 stars 60 forks source link

concurrent processing #79

Closed pegler closed 8 years ago

pegler commented 9 years ago

I used to use this program back when there were separate rip and compress commands and recently upgraded. The old setup had the nice benefit of being able to rip a bunch of movies right in a row and then have it queue the compression step. It seems things have been combined and due to the singleton, the script can only do one thing at a time. Is this intentional? It would be really nice to be able to let the compression run over night after reading in a bunch of DVDs during the day. SQLite supports multiple connections, so there shouldn't be an issue there. Perhaps using lockfile instead of tendo's singleton could accomplish this. Just lock around each call to rip, compress, and extra within autorippr.py

Thanks for all the work you put into this project. It really is great.

JasonMillward commented 9 years ago

The idea behind combining the two scripts was to make it neater (in my opinion) and keep near the same functionality.

It's still possible to rip during the day and compress at night by using separate command line options.

*/5 06-18 * * * python autorippr.py --rip
*/5 19-05 * * * python autorippr.py --compress --extra

But you're right, you can't set it to do multiple tasks concurrently. I guess I made it that way so it didn't spin up drive trays and max out CPU fans at the same time on a HTPC.

Using lockfiles instead could be a better solution compare to using the singleton method.

JasonMillward commented 8 years ago

Closing due to inactivity, if you'd like to submit a pull request to implement lockfiles I'd happily accept one, but I don't have a lot of time currently to test and implement it myself