search

JasonRay168 / pe

0 stars 0 forks source link

Name is not able to support additional words such as s/o #2

Open JasonRay168 opened 8 months ago

JasonRay168 commented 8 months ago

The vcreate implementation uses the prefix s/ to indicate a skill. However, people whose names contain s/o cannot possibly indicate their full legal name. Furthermore, your planned enhancements in DG only takes account of special characters such as periods and commas and label slash symbol as an exception, but does not consider the fact that the suffix s/ for skill can be changed to accommodate for the s/o word in names.

command executed: vcreate n/Frank s/o Harvey p/12345677 e/frankharvey@gmail.com

Resulting message:

New volunteer added: Frank
Phone: 12345677
Email: frankharvey@gmail.com
Skills: o Harvey
Assigned Events:

Person on the list:

image.png

specified planned enhancements in DG:

image.png

soc-se-bot commented 7 months ago

Team's Response

Unfortunately, this would also lead to more pain when dealing with other names with slashes (s/o, d/o, etc.) since we need to make sure that the command format has to change for every possibility. It is easier for us to just restrict slashes in names to mitigate bugs caused by this possibility.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]