JasonRay168 / pe

0 stars 0 forks source link

Picture for implementation of event add volunteer feature is too small #8

Open JasonRay168 opened 10 months ago

JasonRay168 commented 10 months ago

The sequence diagram for event add volunteer feature implementation is very small due to the high number of components involved.

The text for method calls becomes almost unreadable without zooming in.

image.png

nus-se-script commented 10 months ago

Team's Response

Our group's view is that most of us are able to read the words and commands from the DG without having to zoom in. Unfortunately, there is no way for the diagram to be made any bigger since it takes up the whole width of the DG page.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: For starters, I had mentioned that it is "almost unreadable". This is to signify while it is still technically readable, it is very small and uncomfortable to read. After all, we would want the diagrams to be fairly visible.

Also, while you might be able to view the words and commands in the DG, I cannot fully agree with your point that it cannot be made any more visible.

The sequence of actions from when execute(model) is called to when the result is returned can be separated from the whole diagram by reference, and explained in a separate sequence diagram that details that part only.

I believe by doing so, you will be able to reduce the width (not the height) of the main diagram to fit the PDF page better, since originally the large amount of actions involving the Model component classes (Model, Event, Volunteer to be specific) makes the diagram very wide, which results in font sizes being automatically reduced. Furthermore, because the referenced model involves less classes than original, it will also have a smaller width and thus can fit the PDF page better.

In short, using reference, the diagram can be essentially split into 2 diagrams, both with less width and thus can be enlarged on the PDF itself without using zoom.