search

JasonS09 / comfy_sd_krita_plugin

Make AI art between canvas and nodes with Krita.
MIT License
148 stars 7 forks source link

Use PyQt5 imports #24

Closed ElliottLester closed 1 year ago

ElliottLester commented 1 year ago

@JasonS09 can you tell me if this breaks in your environment?

All the Qt objects should be imported directly from the QT package not from krita according to https://docs.krita.org/en/user_manual/python_scripting/krita_python_plugin_howto.html

This means we can run most of the code outside of the krita runtime and stub the krita namespace with https://github.com/rbreu/krita-python-mock So we can make more comprehensive tests.

consistent import order libs pyqt/krita internal

ElliottLester commented 1 year ago

I did test this on my windows machine on Krita 5.3.0 and it seems to load and work so I'm going to say it should be ok.