search

JasonS09 / comfy_sd_krita_plugin

Make AI art between canvas and nodes with Krita.
MIT License
148 stars 7 forks source link

Feature Add: Lora/Embed Auto complete #27

Closed ElliottLester closed 12 months ago

ElliottLester commented 12 months ago

Looking for feedback on:

JasonS09 commented 12 months ago

Looking for feedback on:

  • Shortcuts tab vs enter?
  • Do we need a way to disable this?
  • Any other patterns?
  • Should we use an explicit shortcut to invoke (eg ctrl-e)

Thanks for this PR, it's something I wanted implemented in this plugin. As for how it looks, I don't think there's nothing wrong with the current approach. Making it optional and implementing a shortcut for me seems like an overkill; if for any reason I start seeing the need, or someone requests to implement either, we'll do it then.

Just one thing though, is there a specific reason why you decided to use tab instead of enter for shorcut? I think enter is more intuitive for the users.

ElliottLester commented 12 months ago

Looking for feedback on:

  • Shortcuts tab vs enter?
  • Do we need a way to disable this?
  • Any other patterns?
  • Should we use an explicit shortcut to invoke (eg ctrl-e)

Thanks for this PR, it's something I wanted implemented in this plugin. As for how it looks, I don't think there's nothing wrong with the current approach. Making it optional and implementing a shortcut for me seems like an overkill; if for any reason I start seeing the need, or someone requests to implement either, we'll do it then.

Just one thing though, is there a specific reason why you decided to use tab instead of enter for shorcut? I think enter is more intuitive for the users.

TAB was the default key in the QT documentation for QCompleter and in some IDEs. I have found myself pressing enter, so let me try and implement it and see if there's a conflict with the QPlainTextEdit