search

JasonS09 / comfy_sd_krita_plugin

Make AI art between canvas and nodes with Krita.
MIT License
148 stars 7 forks source link

Live Preview may be broken #8

Closed coreyryanhanson closed 1 year ago

coreyryanhanson commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior: Image generation both using default latent previews and TAESD does not create any previews. During prompt execution, the status says "Executing Prompt... (0 in queue)".

Screenshots Screenshot from 2023-07-31 12-12-31

Desktop (please complete the following information):

JasonS09 commented 1 year ago

Hello. Live preview is not a feature that has been implemented, even though there is a tab remaining from it's previous version. I might consider implementing it if requested, but not really sure how to.

coreyryanhanson commented 1 year ago

That makes sense. I wish I could help, but after looking at the code all I have is a general idea, but don't quite know the finer details of Krita's plugin API to effectively implement it.

It appears there is a method called set_progress_bar_global_hook that gives access to ComfyUI's progress bar and preview images. I'm guessing the plugin's PreviewPage class would need to be refactored to handle the arguments passed to the update_absolute method. I could be wrong and be missing something important, but it seems to be the most promising way I think.

JasonS09 commented 1 year ago

That makes sense. I wish I could help, but after looking at the code all I have is a general idea, but don't quite know the finer details of Krita's plugin API to effectively implement it.

It appears there is a method called set_progress_bar_global_hook that gives access to ComfyUI's progress bar and preview images. I'm guessing the plugin's PreviewPage class would need to be refactored to handle the arguments passed to the update_absolute method. I could be wrong and be missing something important, but it seems to be the most promising way I think.

Problem is that, while developing, I couldn't find a ComfyUI endpoint that could be used for that, so not sure if it's possible.