JasonThon / lightflus

A Lightweight, Cloud-Native Stateful Distributed Dataflow Engine
Apache License 2.0
99 stars 9 forks source link

[feat/LIG-31] 1. done gracefully close dataflow; 2. using async_trait instead of tonic::async_trait #17

Closed JasonThon closed 1 year ago

JasonThon commented 1 year ago

Description

  1. Make a dataflow gracefully close;
  2. using async_trait instead of tonic::async_trait

Impact Scope

  1. terminate dataflow

Test Suggestions

  1. First, you should deploy a dataflow task, word count is recommended;
  2. You can use Postman to call the grpc api TerminateDataflow of Coordinator service to terminate the dataflow
  3. check if word count task is closed by sending a message to kafka;

Tag

No tag

codecov-commenter commented 1 year ago

Codecov Report

Merging #17 (8101918) into master (17cbf00) will decrease coverage by 0.18%. The diff coverage is 49.10%.

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   67.75%   67.57%   -0.19%     
==========================================
  Files          20       21       +1     
  Lines        1560     1656      +96     
==========================================
+ Hits         1057     1119      +62     
- Misses        503      537      +34     
Impacted Files Coverage Δ
src/stream/src/dataflow.rs 58.42% <0.00%> (ø)
src/stream/src/lib.rs 0.00% <ø> (ø)
src/stream/src/actor.rs 53.84% <36.28%> (-2.63%) :arrow_down:
src/common/src/kafka.rs 90.19% <83.33%> (+3.83%) :arrow_up:
src/common/src/db.rs 80.00% <100.00%> (+1.42%) :arrow_up:
src/stream/tests/test_actor.rs 100.00% <100.00%> (ø)
src/common/src/utils.rs 75.00% <0.00%> (+3.75%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more