JasonYapzx / pe

0 stars 0 forks source link

Able to add interviews for past archived applications #5

Open JasonYapzx opened 1 year ago

JasonYapzx commented 1 year ago

Issue

Able to add interviews for archived applications. Assuming the user is a fast typists and did not notice that they are on the archived list, they might possible add an interview to the wrong index / wrong application in the list. As a result, they might prepare for the wrong company / not realise that they have an interview because the interview is stuck on the archived list.

Screenshots

Before adding interview:

image.png

After adding interview to the archived application:

image.png

"Thanks" company interview is not found when listing the non-archived applications:

image.png

Suggestions

To check against the archived status in the parser when adding interviews.

nus-pe-bot commented 1 year ago

Team's Response

Being able to add interviews to past archived applications is an intended feature of the app. This could be done for record keeping purposes. In order for a user to accidentally add interviews to such an application, they would have to somehow mistake this archived application for another application that they actually intended to add to. An archived tag is also shown for archived applications to help users to distinguish archived and unarchived applications easily.

Allowing edits to archived applications is also intended as it brings convenience to users. This idea is also proven by referencing Whatsapp archived chat where the user can still send messages (make modifications) in the archived chat.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]