search

Jasonette / JASONETTE-iOS

📡 Native App over HTTP, on iOS
https://www.jasonette.com
MIT License
5.27k stars 352 forks source link

Implement Switch Component #276

Closed clsource closed 6 years ago

clsource commented 6 years ago

See https://github.com/Jasonette/Jasonette/issues/1 Closes issue #275

Please review. Thanks.

gliechtenstein commented 6 years ago

Thanks for the PR! Does WIP mean i should wait taking a look? Or is it ready to go?

clsource commented 6 years ago

@gliechtenstein I think the code should work, but haven't tested properly with a json. Please look at the code if there's something odd or anything that could be improved.

Then I'll make the changes and properly test the component so it can be merged 👍

Thanks.

clsource commented 6 years ago

I tested, seems to work 👍

darenr commented 6 years ago

@gliechtenstein Would it be possible please to put up an example json for the switch. I looked at the docs but that example doesn't reference the variable "light" anywhere. I tried to do just that and the app crashes. I'm sure I'm doing it wrong. Ideally I'd be able to change between slider and switch pretty much interchangeably in terms of syntax. Also it would be really useful if you could release a new jason app so I could put up a jsonbase example to try.

Thanks!