Jasonette / JASONETTE-iOS

📡 Native App over HTTP, on iOS
https://www.jasonette.com
MIT License
5.27k stars 352 forks source link

video in web component no longer working #302

Closed darenr closed 6 years ago

darenr commented 6 years ago

This used to work, not sure at what point it broke.

https://jasonbase.com/things/gXGB

Thanks

gliechtenstein commented 6 years ago

I haven't touched the HTML components so this wasn't related to Jasonette but rather related to Vimeo itself. Upon taking a look, this looks like it's related to some weird stuff Vimeo guys are experimenting with https://vimeo.com/forums/help/topic:291053

Quick rant but I honestly don't know why they have such a convoluted way to display videos and keep making these weird buggy decisions.

Anyway the solution was to set the transparent=0 params as the above post suggested, and setting the height in absolute instead of percentage. Here's a working version. https://jasonbase.com/things/LV53

darenr commented 6 years ago

that was fast!! Thank you. much appreciated.