Closed CodingGorilla closed 5 years ago
My 30 second review indicates that this is probably because another thread has built the same OptionsInstance<>
and stored it in the root scope before this options instance finished. Is it worth adding a Scope.Service.TryAdd()
that will ignore services that have already been added?
@CodingGorilla Might be the same symptom, but I"m gonna bet it's a separate fix. I've got time right now to look at it.
@CodingGorilla I put in a test to try to break this, but I think the extra locking that came in here (https://github.com/JasperFx/lamar/commit/774e47d74e6159f22a4a05eac2d83119d200afa6) did the trick. And yep, you were right, it was related to #90.
I think this might be related to #90, but I'm not sure. I see this already has locking on it, but I'm getting a lot of these errors all of a sudden (or noticing them all of a sudden).
The stack trace is: