Fix For Issue 258 - Thread Safety

JasperFx / lamar

Fast Inversion of Control Tool and Successor to StructureMap

https://jasperfx.github.io/lamar

MIT License

563 stars 118 forks source link

Fix For Issue 258 - Thread Safety #274

Closed RyanThomas73 closed 3 years ago

RyanThomas73 commented 3 years ago

Fix for issue #258

Changed the Scope.Services property to type ConcurrentDictionary to prevent the thread safety race condition from occurring.
Updated Lamar.AspNetCoreTests.Integration to include a test case that configures and runs a set of health checks, since that is how both reporters on issue 258 have encountered the issue.

jeremydmiller commented 3 years ago

@RyanThomas73 I'm working this one in today. As usual, sorry for the delay and thank you very much for working through this. The only thing I'm changing is swapping out ConcurrentDictionary for the HashMap in ImTools, but that's minor. This will be in Lamar v5.0.3 in the next couple days as I do a Lamar bug sweep

jeremydmiller commented 3 years ago

It with a rebase.