JasperFx / oakton

Parsing and Utilities for Command Line Tools in .Net
http://jasperfx.github.io/oakton
Apache License 2.0
308 stars 41 forks source link

Use DisposeAsync with scopes and hosts #99

Closed ArturDorochowicz closed 2 months ago

ArturDorochowicz commented 2 months ago

This is about using async where it's available.

Some of the changed places used SafeDispose() earlier. Not sure how important that was, but it wasn't used consistently.

jeremydmiller commented 2 months ago

SafeDispose is trying to swallow any exceptions from Dispose(), which isn't terribly uncommon here and there