JasperFx / weasel

Database Development Made Easy for .Net
MIT License
65 stars 21 forks source link

Detects primary key constraint name change when migrating #39 #40

Closed tonykaralis closed 2 years ago

tonykaralis commented 2 years ago
tonykaralis commented 2 years ago

@oskardudycz mine is slightly different to yours. Some sql code what was this for?

oskardudycz commented 2 years ago

@tonykaralis, I didn't notice that there is an index name already in the other select. Your version is better 👍 Thanks for busting that! 🙂

tonykaralis commented 2 years ago

@oskardudycz Thank you appreciate it, although I have 2 failing tests now on this branch :/

tonykaralis commented 2 years ago

Perhaps we could rerun the tests once more? I haven't been able to reproduce the failing tests locally.

oskardudycz commented 2 years ago

I've rerun them. Let's see 😉

oskardudycz commented 2 years ago

@tonykaralis, it looks like we have some flakiness, a different set of tests failed, but also the main branch seems to have issues. I'm probably going to pull the trigger tomorrow morning.

tonykaralis commented 2 years ago

Thank you, much appreciated!!

oskardudycz commented 2 years ago

Pulling that in, as test flakiness seems to be unrelated to the pull request.

tonykaralis commented 2 years ago

Closes #39