search

JasperFx / weasel

Database Development Made Easy for .Net
MIT License
65 stars 21 forks source link

Fix issue with retrieving table indexes #67

Closed jabellard closed 2 years ago

jabellard commented 2 years ago

When creating a database patch, there's an issue with the patch containing creation instructions for indexes that already exists in the database. This issue affects only some Postgres versions. From what I've observed, it's not a problem on a Postgres instance with version PostgreSQL 10.7 on x86_64-pc-linux-gnu, compiled by gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28), 64-bit, but is an issue on another instance with version PostgreSQL 12.4 on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0, 64-bit.

The problem originates from how casting pg_index.indexrelid to regclass behaves on different versions of Postgres. On some versions, pg_index.indexrelid::regclass returns the qualified name of the table that the index belongs to. However, on some other versions pg_index.indexrelid::regclass returns just the name of the table without the schema qualifier.

This enhancement fixes this issue.

jabellard commented 2 years ago

@jeremydmiller, can you please take a look?