search

JasperFx / weasel

Database Development Made Easy for .Net
MIT License
65 stars 19 forks source link

Set default table creation style to `CreationStyle.CreateIfNotExists` #92

Open jabellard opened 12 months ago

jabellard commented 12 months ago

I'm pushing this PR to ensure that the default table creation style is CreationStyle.CreateIfNotExists.

The motivation for this change is safety. Given that applying a migration script is a process that is prone to human errors, I think it's wise to safeguard against such errors as much as possible.

With the default as CreationStyle.DropThenCreate, if any migration script is run a second time by mistake, then tables can be dropped, resulting in a loss of data, which can be catastrophic in a production environment.

jeremydmiller commented 11 months ago

@jabellard Dude, we can't change default behavior without a major version change. And this broke a lot of tests that would have to be adjusted. I think you'd need to wait for a major Weasel & a major Marten release to pull this off.