search

Jaspertzx / pe

0 stars 0 forks source link

JSON Storage file object is mislabelled as "persons" #5

Open Jaspertzx opened 2 months ago

Jaspertzx commented 2 months ago

Details: The object in the Json file is mislabelled. This may confuse users who are manually editing the file and see a random object named "persons:"

Steps to reproduce:

  1. Run the application.
  2. Exit the application.
  3. Go to the data/addressbook.json
  4. Open it with your file editor of choice

Expected: A properly labelled object either interviewApplications or applications etc.

Actual: An object called persons

Screenshots: image.png

Rationale: This could be extremely confusing to users as they may not know what they are editing. (It was confusing to me when editing the storage folder too!)

nus-pe-bot commented 2 months ago

Team's Response

It does not affect the usage of our app

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]