search

Jaspertzx / pe

0 stars 0 forks source link

Storage Json File is misnamed #6

Open Jaspertzx opened 2 months ago

Jaspertzx commented 2 months ago

Details: The storage file is named as "addressbook.json". However, there is no addressbook here, but rather the user's applications. This should be labelled either something more generic such as "data.json" or even "applications.json", otherwise users who are editing the JSON file might be confused as to what they are editing.

Steps to reproduce:

  1. Run the application
  2. Close the application
  3. Check the file name in data directory of the application home address

Expected: An well named storage file to indicate storage of data in the Internhub.

Actual: A file called addressbook.json

Screenshots:

image.png

nus-se-script commented 2 months ago

Team's Response

AddressBook technically suits our product because our internship applications do contain the field "Address"

The naming convention follows our code base, perhaps in the future we can update the naming to fit the product better.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]