Jatin-Shihora / DSA-Essentials_Core-CS

All essential Data Structures and Algorithms with different programming languages.
MIT License
14 stars 12 forks source link

Binaryinsertionsort #16

Closed jawadkhanpk closed 2 years ago

jawadkhanpk commented 2 years ago

Assigned Issue Number?

4

Language Opted?

Number of files added or updated?

Name of these files?

Checklist

🌟 this repository and support.

Jatin-Shihora commented 2 years ago

@jawadkhanpk you must make a new branch for every new pull request so that commits don't get entangled. For example in this request, you have committed 3 times and added 2 files & those two files are BucketSort and BinaryInsertionSort but you may know that just a few mins ago I merged your BucketSort.js. So now if I merge this #16 pull request it will again recommit that same file + your newly added BinaryInsertionSort. So don't you think your last commit will get counted as spam since it will have no significance & this #16 commit will become inappropriate since it explicitly asks for BinaryInsertionSort and not BucketSort.

jawadkhanpk commented 2 years ago

sorry for Inconveniences let me make it better in few moments