JavGVastro / PhD.Paper

This repository contains updated methods for the project H II regions Structure functions (previously CSHR).
0 stars 2 forks source link

Deal with referee report #16

Closed will-henney closed 1 year ago

will-henney commented 1 year ago

We now have the referee report on the paper, which had only one comment that needs to be addressed:

will be happy to recommend the manuscript for publication after some clarification of some details:

  • To study the Finite box effects, as well as that of seeing the authors do an interesting exercise with idealized data (as fractional Brownian motion -fBm- 2D data modified to include a correlation taper). This approach is very clear, but there is one issue that requires attention, and that is that of the projection from a 3D field to a 2D field. In reality the density/velocity fields are three-dimensional but some information is lost in the projection to a 2D map.

For the exercise presented in appendix A, the authors use a 2D map that was modified to include the proper spectral index (n_2D = m +2) and a correlation length r_0, in reality one would have a 3D map with a spectral index (n_3D = m +3), which if integrated along the line of sight would change the spectral index from n_3D to n_2D (and within the transition some inertial range could be 'lost') .

In other words in the current version of the paper the r_0 is entirely in the plane of the sky, while in reality should correspond to the 3D field, and at the same time the transition from a 3D to a 2D map could curve more the structure functions. I believe that it would be beneficial to obtain the 2D map from collapsing a 3D fBm (with an index m+3) and the same exponential taper used and verify that the main results hold, or discuss this an additional limitation.

will-henney commented 1 year ago

In order to deal with this, we need to generate a fake 3d velocity cube:

Then we should look at the velocity maps to make sure they are OK. Up to here can be in one notebook. We should save the velocity maps for each value of the seeing.

From then on, the calculation of the structure function is the same as we had previously.

will-henney commented 1 year ago

Javier has finished an initial exploration of this in Fake-Maps/fake-3d-tapered-maps.ipynb

The results look promising. I just have a few queries:

will-henney commented 1 year ago

Then the following steps will be:

will-henney commented 1 year ago

Comment on the edge effects: we should make sure to use boundary="fill" in convolve_fft()

will-henney commented 1 year ago

Comment on the power law slopes: I think we should maybe be using 2 + m instead of 3 + m for the slope of the power spectrum

But @JavGVastro should check this in the literature

JavGVastro commented 1 year ago

Emissivity fluctuations case

firefox_F5LOmpuf5N

image470

firefox_ynBWHo3KTU

Finite maps results

firefox_9nqxWEjWGy

firefox_xLYG9Bwn6h

JavGVastro commented 1 year ago

Here is a summary of the case that is going to be used to update the paper. Also, there are the images files locations so everything can be easily found, tracked and reviewed.

Emissivity fluctuations case: $\sigma_E = 1$

firefox_vwlxDr7eOO

Image file: _PhD.Paper/Fake-Maps/fake-3d-maps/sf-fake-3d-maps-emissivity-fluct_m1_sigE1.ipynb

-Comparison of the Initial structure functions of the 1st moment map.

firefox_IfMfbxLd8B

Image file: _PhD.Paper/Fake-Maps/fake-3d-maps/sf-fake-3d-maps-emissivity-fluct_m1_sigE1.ipynb

Imagen sin título

Image file: _PhD.Paper/Fake-Maps/fake-3d-maps/ci-fake-3d-maps-emissivity-fluct_m1_sigE1.ipynb

Conclusion: The behaviour is shared as in the 2D case in the reduction of $\sigma$ and $r_0$ following the finite box analysis where the condition to recover $r_0$ is $(L > 10 r_0)$. The main difference is that the condition $(L > 3 r_0)$ to recover $r_0$ changes to $(L > 5 r_0)$ when applyting a fit to the results. The dashes line still is described by $1 - e^{L / x r_0}$ but with $x$ equal to $4.0$ instead of $3.6$ (2D maps).

imagen

imagen

imagen

imagen

Images File: _PhD.Paper/Fake-Maps/fake-3d-maps/fake-3d-maps-finite-ems-fluct-SigE1.ipynb

  1. Create maps with their respective seeing:

imagen

Image file: _PhD.Paper/Fake-Maps/fake-3d-maps/create-fake-3d-maps-seeing-nonp-ems-fluct-sigE1.ipynb

  1. Compute structure functions.

File: _PhD.Paper/Fake-Maps/fake-3d-maps/sfs-fake-3d-maps-seeing-nonp-ems-fluc-sigE1.ipynb

  1. Analysis on the reduction of $B(r)$ with respect differents s0.

The model changed from:

$S(r; s_0, r_0) = \frac{e^{-s_0 / r_0}}{1+(2s_0 / r)^{2a}}$ to

$S(r; s_0, r_0) = \left [ \left (1+\frac{1.25 s_0}{r_0} \right) \left(1+ \left (\frac{2.6 s_0}{r} \right) ^{2a} \right) \right ]^{-1}$

with $a = 0.75$

imagen

Image file: _PhD.Paper/Fake-Maps/fake-3d-maps/fake-3d-maps-structure-function-analysis-ems-fluc_m4-sig_E1.ipynb

Note: The analysis of the new model is here: _PhD.Paper/Fake-Maps/fake-3d-maps/ratio_seeingnewmodel.ipynb

JavGVastro commented 1 year ago

$S(r; s_0, r_0) = \left [ \left (1+a_1\frac{ s_0}{r_0} \right) \left(1+ \left (a_2 \frac{s_0}{r} \right) ^{a_3} \right) \right ]^{-1}$

imagen

imagen

imagen

Fake-Maps/fake-3d-maps/ratio_seeing_newmodel-global.ipynb