search

JavaCS3 / xterm-player

a web based terminal recording player
https://javacs3.github.io/xterm-player/
MIT License
105 stars 9 forks source link

`require('xterm-player')` leads to `window` is not defined in node env #12

Open JavaCS3 opened 4 years ago

JavaCS3 commented 4 years ago

looks like a webpack 4 bug https://medium.com/@JakeXiao/window-is-undefined-in-umd-library-output-for-webpack4-858af1b881df

JavaCS3 commented 4 years ago

In v0.0.8

> require('xterm-player')
Thrown:
ReferenceError: window is not defined
    at Object.<anonymous> (/private/tmp/test/node_modules/xterm/lib/xterm.js:1:224)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at webpackUniversalModuleDefinition (/private/tmp/test/node_modules/xterm-player/dist/js/xterm-player.js:3:28)

This should be fixed in xterm.js https://github.com/xtermjs/xterm.js/issues/2749