search

JavaCS3 / xterm-player

a web based terminal recording player
https://javacs3.github.io/xterm-player/
MIT License
104 stars 9 forks source link

[Feature Request] Support more xterm.js custom settings #23

Closed forest0 closed 4 years ago

forest0 commented 4 years ago

Actually, xterm.js provides lots of options that can be used to customize terminal(e.g., many people want to change font or theme.), can we expose all or some of options in xterm.ITerminalOptions to user?

JavaCS3 commented 4 years ago

I think some of options from xterm.ITerminalOptions should be viable. Can you provide a list about which options do you want most? Since there's only me working on this project. If you can't wait this feature, please create a PR. Your contribution will be a great helpful.

forest0 commented 4 years ago

Thanks for your quick response.

Can you provide a list about which options do you want most?

I have cloned your repo to my local to implement what I want, to be honest, I know little about TypeScript, so maybe I will create a PR after I know some basics about TypeScript.

I appreciate your works, maybe you can implement some other important features first, since I am not that hurry.😄

JavaCS3 commented 4 years ago

@forest0 Typescript is not hard to learn if you're already familiar with other languages like Java, JS. Actually I didn't spend too much time learning TS. I learnt it while I was contributing to xterm.js. You will soon get used to it after you changing some lines of code or reading code. Just go for it.

BTW, Seems like you can speak Chinese and your English it well too. The reason why I use English to communicate are 1. I want my project to be globalized 2. improve my English writing skills.

forest0 commented 4 years ago

Yeah, think so.

Do you have a telegram account? Maybe we can create a telegram group of this project, or one group on gitter.im?

JavaCS3 commented 4 years ago

https://gitter.im/xterm-player/community

JavaCS3 commented 4 years ago

24 #25