JavaCS3 / xterm-player

a web based terminal recording player
https://javacs3.github.io/xterm-player/
MIT License
104 stars 9 forks source link

style suggestion #41

Open royl88 opened 3 years ago

royl88 commented 3 years ago
  1. i think change Icons.Pause to Icons.Play when state=="Paused" looks better. src/ui/PlayerView.ts
      case 'Paused':
        this._bigButton.style.display = 'block'
        // change icon
        this._bigButton.innerHTML = Icons.Play
        this._spinner.style.display = 'none'
        break
  1. better close rate-setting-box after changed rate src/ui/ControlBarView.ts
    addDisposableDomListener(this._playbackRate, 'click', () => {
      this._playbackRateSettingBox.classList.toggle('xp-setting-box-open')
    })
    this._playbackRateItems.forEach(item => {
      addDisposableDomListener(item, 'click', () => {
        this._player.playbackRate = parseFloat(item.dataset['rate'] || '1')
        // add this
        this._playbackRateSettingBox.classList.toggle('xp-setting-box-open')
      })
    })