search

JavaJens / TextSecure

A secure text messaging application for Android.
GNU General Public License v3.0
71 stars 9 forks source link

Add registration warning popup to websocket-only users without GCM #24

Closed relyt29 closed 8 years ago

relyt29 commented 9 years ago

So if you look at the old way RegistrationActivity.java does this there's a race condition in the UI between the "No google play warning" and the "are you sure this is your phone number?" warning. Additionally I think its important to warn users of the websocket branch that its possible the code will be very buggy and unstable. screen

relyt29 commented 9 years ago

Well, do you want to show the warning to all users who run the websocket-reborn branch, or just those who run websocket-reborn and don't have gApps? My thinking was to warn those without gApps, because even if you're using websocket-reborn but you have gApps, all the API calls to gApp libraries will still work, so it probably won't be buggy the same way it's buggy without gApps

JavaJens commented 9 years ago

So you want to show the warning only to those that don't have gApps, but still use Websockets for those that have gApps with issues? That sounds like a viable approach as well :+1:

relyt29 commented 9 years ago

According to my understanding, as of the current status of this PR, that's what will happen. Non gApps/fucked up gApps users will see the warning, and people with working gApps still use websockets, but don't get any warning about strange bugs and/or issues.

relyt29 commented 9 years ago

Closing for now

JavaJens commented 9 years ago

Sorry this was left idle so long. If anyone feels that such a warning dialog is needed, feel free to reopen. Also, I'd immediately merge a PR that just adds the warning dialog without not supporting the user, basically removing lines 216 and 220. I just think that if we have the ability to support devices that have a broken GCM setup, they still should be able to use the App with websockets until their setup is fixed.

JavaJens commented 9 years ago

I have created a PR, but haven't tested that. Especially interesting would be the behavior if both dialogs will be displayed. Please comment :smile:

relyt29 commented 9 years ago

Why was this reopened/closed? I'm confused what the status is right now and what our goals are. I believe I did test your PR in #28