search

JavaMoney / javamoney-examples

JavaMoney - Examples
Apache License 2.0
86 stars 39 forks source link

reflects the new package of javafx Utils #26

Closed ohumbel closed 8 years ago

ohumbel commented 8 years ago

The internal package of the javafx Utils class has changed, see https://bitbucket.org/controlsfx/controlsfx/issues/526/comsunjavafxutils-changes-to. This small fix allows the examples to be compiled with a current JDK 8 ( >= 1.8.0_60 )

keilw commented 8 years ago

Thanks, but as the "preview" shows, this PR will break on Travis-CI. It's JDK is java version "1.8.0_31" and until hinted workarounds like http://stackoverflow.com/questions/29636754/can-you-specify-minor-jdk-version-for-travis-ci are really in place for Travis, I'm afraid we'll have to postpone merging it.

keilw commented 8 years ago

Given the use of "com.sun" packages is highly discouraged and similar to (now defunct or renamed) http://cr.openjdk.java.net/~ckyang/RT-33209/webrev.00/modules/base/src/main/java/com/sun/javafx/PlatformUtil.java-.html the method turns out to be just a one- or two-liner, we might prefer to offer something similar in a place like JavaMoney-lib.

ohumbel commented 8 years ago

No problem for me, that is perfectly OK. I was preparing for tonight's Hackergarten, and wanted to have a clean Eclipse workspace...

keilw commented 8 years ago

Actually JavaFX is full of redundancies (not just duplicating e.g. JSR310 Duration instead of simply using it by now ;-) and com.sun.javafx.PlatformUtil is still in the same place, so could you try that? (assuming it was already in 1.8.0_31, too) Anatole won't come, but I should be in the Hackergarten at least a bit after 6.

keilw commented 8 years ago

Of course the JavaFX Duration is much closer to e.g. BigDecimal with add(), subtract(),... while JSR 310 as only class in the whole JDK introduced some random mix of Scala or Groovy style methods like plus(), minus(),... ;-)