JavaMoney / javamoney-shelter

A shelter for new ideas and modules to be adopted, e.g. via Adopt-a-JSR
Apache License 2.0
6 stars 6 forks source link

Basic Groovy Demo script and Spock tests #5

Closed msgilligan closed 9 years ago

msgilligan commented 9 years ago

This is some early experimentation, any feedback or suggestions would be greatly appreciated. It's proof of concept for adding Groovy operators for all arithmetic operations in the core JavaMoney classes.

msgilligan commented 9 years ago

Note: I need to add the following info to the README

To run the demo command line app:

cd groovylang-support/groovy-demo
./gradlew run

The output will be displayed to the console.

To run the Spock tests:

cd groovylang-support/groovy-demo
./gradlew test

The test results will be in build/reports/tests/index.html

stokito commented 9 years ago

I merged, thanks for your contribution @msgilligan!

msgilligan commented 9 years ago

Thanks for accepting my pull request! Since I have write access, I'm going to go ahead and make improvements to this groovylang-support subdirectory directly, OK? @stokito @keilw

stokito commented 9 years ago

Yep, I'll try to review your changes, but your code looks perfect, so go ahead ;-)

msgilligan commented 9 years ago

Awesome. Next step is to extract Groovy metaclass changes to an external file, create a CompilerConfiguration, and add the remaining operators. Change review and feedback would be greatly appreciated. So would any additional Spock tests you might come up with.

I also want to start work on a Java language implementation of a BitcoinProvider for the CurrencyProviderSpi using the code in the User Guide as a starting point. I'm planning on creating a PR for that (when I get the time to do it.)