search

JavaMoney / javamoney-shelter

A shelter for new ideas and modules to be adopted, e.g. via Adopt-a-JSR
Apache License 2.0
6 stars 6 forks source link

Use Spock tests for digital-currency/bitcoin module #8

Closed msgilligan closed 9 years ago

msgilligan commented 9 years ago

As you may have noticed, I'm a big fan of the Spock Framework. Would anyone else be interested in using it instead of (or in addition to) JUnit for the 'digital-currency/bitcoin' module?

stokito commented 9 years ago

:+1: I even cant image how to write useful tests without Spock

msgilligan commented 9 years ago

@keilw What do you think?

I would initially add Spock support to the POM and convert the JUnit file that I wrote to Spock. JUnit and Spock could co-exist for a while, but we could also decide to go 100% Spock.

keilw commented 9 years ago

All tests I know for main JSR 354 were changed from JUnit to TestNG AFAIK, but being an expert in Agile, DevOps or BDD myself I see no problem using Spock at least in the Shelter. Could provide experience for other JavaMoney projects later;-) so +1

msgilligan commented 9 years ago

OK, I'll try to put together a pull request for it within the next week. I'll update pom.xml and create a few sample Spock tests (converting what I've already written.)

msgilligan commented 9 years ago

Implemented in PR #14.