JavaMoney / jsr354-api

JSR 354 - Money and Currency API
http://javamoney.org
Apache License 2.0
357 stars 79 forks source link

Remnants of timestamp support still present #120

Open marschall opened 5 years ago

marschall commented 5 years ago

Even though timestamp support was removed in JAVAMONEY-89 it is still referenced in several places.

keilw commented 5 years ago

Seems removed by PRs like https://github.com/JavaMoney/jsr354-api/pull/119. What about the BP, do we care or leave it there? As it should go away with the next version, I am not sure, if it would break anything there, if not, then we may just keep it as it is.

marschall commented 5 years ago

119 removes only one part, more remains to do

Removing AbstractQuery#KEY_QUERY_TIMESTAMP is a breaking change, I'm not sure we want to do this, maybe only deprecate. As for the BP I'm not sure what the policy is. Most of these things are cosmetic only and do not affect functionality.