search

JavaMoney / jsr354-api

JSR 354 - Money and Currency API
http://javamoney.org
Apache License 2.0
357 stars 79 forks source link

call delegate '#getService()' when looking up single service #132

Open theborakompanioni opened 3 years ago

theborakompanioni commented 3 years ago

as classes implementing ServiceProvider may define their own custom behaviour, let the ServiceProvider instance itself fetch a single service by name instead of using an own standard strategy (using the first one returned by #getServices(Class))

this way it is prevented that a ServiceProvider must load all services of the class even if they are not generellay needed (including all side effects e.g. loading data from remote services)

This change is Reviewable

keilw commented 3 years ago

Are you a JCP member? Because we cannot accept PRs from non-members in the API, RI or TCK repositories. We just had a MR1, so it may be up to the next version, if you are able to join the JCP we'd be happy to accept the PR.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.01%) to 78.212% when pulling dd4cc062a6041788b9cd50fbe65a40444c3251d1 on theborakompanioni:master into 9f64034e01550dcc593cb3b81ba79103a82c82c8 on JavaMoney:master.

theborakompanioni commented 3 years ago

Hey @keilw! Thanks for your response. Unfortunately I cannot do that, as it requires an Oracle account, which I wont create (jcp.org accounts are integrated with Oracle's Single Sign-On (SSO) login mechanism). Would it be possible to apply the changes in an other way, e.g. by adding them yourself? I do not mind not being the author of the changes. You can do whatever you want. I hereby grant all power to you.

Thank you for your time and service.

keilw commented 3 years ago

We have to see, the general mechanism is not different from other JSRs but it needs to wait till a really new JSR anyway.

theborakompanioni commented 2 years ago

Any updates on this @keilw ?

keilw commented 2 years ago

No @theborakompanioni there is no new JSR so it'll have to wait. We have to get the 3rd Spec Lead which was recently aqcuired by Accenture, so hard to say, if they are still interested and available for that kind of stuff.