search

JavaMoney / jsr354-ri-bp

Backport of the JSR 354 RI compatible with Java prior to SE8.
Other
9 stars 14 forks source link

Backport of JAVAMONEY-160 #36

Closed lukasniemeier-zalando closed 6 years ago

lukasniemeier-zalando commented 7 years ago

See https://github.com/JavaMoney/jsr354-ri/commit/12bb383699a72aae8f8e1e23ba3c55ff3f3c6278

This change is Reviewable

lukasniemeier-zalando commented 7 years ago

FYI on master my build is succeeding but signals failing tests

Failed tests:                                                                                                                                                                                                 
  IMFRateProviderTest.shouldConvertsBrazilianToDollar:132 » CurrencyConversion C...                                                                                                        
  IMFRateProviderTest.shouldConvertsDollarToBrazilian:145 » CurrencyConversion C...                                                                                                                           
  IMFRateProviderTest.shouldConvertsDollarToEuro:106 » CurrencyConversion Cannot...                                                                                                                           
  IMFRateProviderTest.shouldConvertsEuroToDollar:119 » CurrencyConversion Cannot...                                                                                                                           

Tests run: 452, Failures: 4, Errors: 0, Skipped: 0                                                                                                                                                            

[ERROR] There are test failures.
keilw commented 7 years ago

The Travis build claims it passed. Won't merge now, but try later this evening. Thanks.

keilw commented 7 years ago

Please note, the BP currently is not modularized. As this is sort of a Jigsaw ease preparation in Moneta, if there is no negative side-effect, the BP might stay that way.

lukasniemeier-zalando commented 7 years ago

Any update? Do you miss something from me?

keilw commented 7 years ago

I believe this one could be OK, but there are a couple of other issues (mostly in Moneta, but BP also partly affected) we must resolve before a new build makes sense.

keilw commented 7 years ago

@lukasniemeier-zalando Any news on the JCP Associate Membership?