FastMoney.negate and FastMoney.abs no not work on Java SE 8.

marschall commented 6 years ago

After some analysis I believe I found the issue behind #189. I think the classes have been miscompiled and need to be recompiled and republished. I think what happened here is the following:

FastMoney.negate is implemented in terms of Math.multiplyExact(this.number, -1), see https://github.com/JavaMoney/jsr354-ri/blob/master/moneta-core/src/main/java/org/javamoney/moneta/FastMoney.java#L396 as you can see a int rather than a long literal is used.
On Java 8 the only matching overloaded method is java.lang.Math.multiplyExact(long, long), so this one is chosen
With Java 9 there is a new method java.lang.Math.multiplyExact(long, int) so this one is chosen.

The issue is that he project got compiled on Java 9 with -source 1.8 -target 1.8. Unfortunately this is not a safe way to do cross compilation as seen in this example. Before Java 9 you had to follow the rules outlined in Cross-Compilation Options which comes down to using -bootclasspath. This is not very convenient to use so with Java 9 there is now -release. It is my option that the project needs to be built either on Java 8 or on Java 9 with -release 8. Building on Java 9 with -source 1.8 -target 1.8 is not safe.

MALPI commented 5 years ago

Hey there, is there any chance that you publish a new artifact for that? We are facing this issue right now.

keilw commented 5 years ago

@MALPI As the MR1 is not complete, please bare with us, there will be a new release if everything was addressed. In the meantime, could you check out the latest SNAPSHOT build of Moneta?

JavaMoney / jsr354-ri

FastMoney.negate and FastMoney.abs no not work on Java SE 8. #223