search

JavaMoney / jsr354-ri

JSR 354 - Moneta: Reference Implementation
Other
344 stars 101 forks source link

Inconsistent formatting white space #261

Closed marschall closed 4 years ago

marschall commented 5 years ago

The project uses a mix of spaces and tabs, for example see https://github.com/JavaMoney/jsr354-ri/blob/master/moneta-core/src/test/java/org/javamoney/moneta/format/MonetaryFormatsTest.java it would be could if the project could settle on one style and apply it consistently.

stokito commented 5 years ago

I think we should setup some checkstyle plugin to avoid such problems in the feature. Code style should be similar to OpenJDK i.e. spaces.

keilw commented 5 years ago

Is this about https://github.com/JavaMoney/jsr354-ri/issues/193 or just code format? Again, these are nice to have, but we can leave this for later, the important thing is the functional outcome of Monetary parsing.

marschall commented 5 years ago

@keilw this is not related to #193 but about the code style of the source files.