JavaMoney / jsr354-ri

JSR 354 - Moneta: Reference Implementation
Other
344 stars 101 forks source link

Fix parsing and formatting amounts with a space as thousand separator #278

Closed stokito closed 5 years ago

stokito commented 5 years ago

This PR is fixes #193 #210 #202 and related to #151 Please let's discuss everything in scope of #193

The PR is not fully backward compatible - after the change c5a49ac33844d62c41e926a0e1164dd406b6057f if parsed input string contains tab \t then previously this will be just trimmed but now it will fail. But normally this should not affect anyone.

Note that there is still some bugs which are mostly covered with a unit test assertions that are commented with //FIXME

For example amounts with minus sign may be improperly parsed.


This change is Reviewable