JavaMoney / jsr354-ri

JSR 354 - Moneta: Reference Implementation
Other
343 stars 101 forks source link

Set formater logs to fine #349

Closed sanmibuh closed 2 years ago

sanmibuh commented 3 years ago

With info level, we could have a lot of noise in normal execution.


This change is Reviewable

keilw commented 3 years ago

Thank you @sanmibuh it looks reasonable but are you a JCP member? For the RI or API+TCK one has to be at least an associate member of the JCP, see https://jcp.org/en/participation/membership. Guess this is not so time-critical, but if you have problems joining, we might have to use another way (e.g. close this and raise an issue for others to apply) for getting this request done.

sanmibuh commented 3 years ago

I'm not a JCP member, sorry 😒

keilw commented 3 years ago

Then if you don't see a chance to join (it's free) we'd have to do it for you.

sanmibuh commented 3 years ago

I'm checking to be a member πŸ˜ƒ

keilw commented 3 years ago

Cool, then let us know, if you need any help or if we may find your name on the JCP members list to progress this further.

sanmibuh commented 3 years ago

I am already registered, waiting to receive the agreement to sign it. My username is the same as on GitHub: sanmibuh@gmail.com

sanmibuh commented 3 years ago

Hi, Just signed the agreement 😁

keilw commented 3 years ago

Good, then hope your name shows up there soon, If you wanted to speed things up you could forward a confirmation by PMO to our support mail found on our support mail on http://javamoney.github.io/.

sanmibuh commented 3 years ago

Hello @keilw, I'm already JCP Associate Member :)

keilw commented 3 years ago

Great, could you send us a confirmation to the email address mentioned on the JavaMoney page (support@...) because under https://jcp.org/en/participation/members/V I see a "Lorenco Vicente" but that does not seem to be you, or do you have a different nickname here?

keilw commented 3 years ago

@otaviojava Thanks for approving it, let's wait with the merge until either the PMO (on jcp.org) or @sanmibuh also sends the confirmation of the Associate Membership.

sanmibuh commented 3 years ago

Hello @keilw Check here: https://jcp.org/en/participation/members/B : David Belmez Vicente Im Spanish, so David is my name and Belmez my first surname and Vicente is my second surname

odrotbohm commented 3 years ago

May I suggest to also tweak the log messages? They indicated that the method is only called from toString() when in fact parse(CharSequence) calls it, too.

keilw commented 3 years ago

Glad to see JCP membership has been sorted out, but we are waiting for something else to sort out, until https://issues.sonatype.org/browse/OSSRH-68317 got fixed with Sonatype, all changes to this or any other JavaMoney repo are suspended. Sorry for the delay, it isn't our fault and we have to hope it gets fixed soon.

Kevincifuentes commented 2 years ago

Any news about this? It seems that the blocking issue is fixed, isn't it?

commodis commented 2 years ago

@keilw is there some reason why this PR can not be merged and published?

keilw commented 2 years ago

@commodis Were still waiting for the JCP Membership to show, but it seems there now.

sanmibuh commented 2 years ago

@commodis Were still waiting for the JCP Membership to show, but it seems there now.

Im JCP member: https://github.com/JavaMoney/jsr354-ri/pull/349#issuecomment-797016519

Belmez Vicente, David

commodis commented 2 years ago

When will this change be released?