search

JavaMoney / jsr354-ri

JSR 354 - Moneta: Reference Implementation
Other
332 stars 99 forks source link

AWG cash rounding is not supported #407

Open Testsubject1683 opened 6 months ago

Testsubject1683 commented 6 months ago

Arubian Florin has 5 cents as the smallest denomination. Currently Moneta has no special handling for cash rounding with AWG. I already created a PR which should fix it https://github.com/JavaMoney/jsr354-ri/pull/405

sschuerz commented 5 months ago

Is there a chance to get this fixed timely?

sschuerz commented 4 months ago

Is there a chance to timely get a release including the change?

keilw commented 4 months ago

@sschuerz Could you test it in the 1.4.5-SNAPSHOT build? We still have a few issues to solve: https://github.com/JavaMoney/jsr354-ri/milestone/11 Of those only #413 is negotiable, because it mainly affects testing, we could shift it to 1.5 or 1.4.6, the others need to be resolved before we do a new release.

sschuerz commented 3 months ago

@keilw Sorry for the late response. I think testing with a snapshot version on our side is not required since it is quite clear what the effect of the change will be. And as we cannot productively use the snapshot version, I think we will have to wait for the final 1.4.5 release. Thanks anyway!