search

JavaPOSWorkingGroup / javapos-contracts

Hosts the interfaces and data types of the UnifiedPOS reference implementation for Java.
Other
8 stars 9 forks source link

Enhancements according to UPOS 1.14.1 and 1.15 #13

Closed mjpcger closed 2 years ago

mjpcger commented 2 years ago

...service115 and ...control115 interfaces added for all devices. Additional properties and methods to really support UPOS 1.14.1 and 1.15 are part of the new interfaces.

mjpcger commented 2 years ago

Further remark: Constants added in UPOS 1.14.1 and UPOS 1.15 have been added to FiscalPrinterConst and ElectronicValueRWConst, too.

kuniss commented 2 years ago

@mjpcger, please open a separate PR for the ElectronicRW constant correction for issue #14. Even if this seems to be more work, we need to have the changes reproducible for that public repo. The constant corrections are not related to 1.15! Just make a branch for your issue, copy the changes to there and provide a 2nd PR. Revert the corresponding changes here at that PR. Thanks in advance!

mjpcger commented 2 years ago

Changes made as requested. Remark: EVWR methods updateKey and activateService use the same Object[] type instead of Object for parameter obj as I used in the previous version. This is the reason why I did it wrong. Perhaps this should be corrected as well.

mjpcger commented 2 years ago

I'll do it asap.

Am 18.05.22 um 20:57 schrieb Denis Kuniß:

@.**** commented on this pull request.

In src/main/java/jpos/ElectronicValueRWControl115.java https://github.com/JavaPOSWorkingGroup/javapos-contracts/pull/13#discussion_r876242803:

  • public String getDailyLog() throws JposException;
  • public int getPaymentCondition() throws JposException;
  • public String getPaymentDetail() throws JposException;
  • public int getPaymentMedia() throws JposException;
  • public String getSlipNumber() throws JposException;
  • public String getTransactionNumber() throws JposException;
  • public int getTransactionType() throws JposException;
  • public int getServiceType() throws JposException; // 1.14.1
  • // Methods
  • public void accessDailyLog(int sequenceNumber,
  • int type,
  • int timeout) throws JposException;
  • public void accessData(int dataType,
  • int[] data,
  • Object[] object) throws JposException; // 1.14.1

I agree! Do you change it back to your original implementation then?

Sorry for having caused this additional effort!

— Reply to this email directly, view it on GitHub https://github.com/JavaPOSWorkingGroup/javapos-contracts/pull/13#discussion_r876242803, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI7UND6JBIQWDO6PDNC3ENLVKU4SVANCNFSM5TAPEPGA. You are receiving this because you were mentioned.Message ID: @.***>