search

JavaPOSWorkingGroup / javapos-contracts

Hosts the interfaces and data types of the UnifiedPOS reference implementation for Java.
Other
8 stars 9 forks source link

ElectronicValueRW: Extended error codes have OPOS_ prefix #14

Closed mjpcger closed 1 year ago

mjpcger commented 2 years ago

The ExtenderError constants for the ElectronicValueRW device class have names starting with OPOS_. This is probably wrong. The names shoud be the names as specified in the UPOS specification. In addition: There are error codes OPOS_EVRW_NOCARD and OPOS_EVRW_RELEASE defined, but I cannot find any related specification for extender errors EVRW_NOCARD or EVRW_RELEASE within the UPOS specification. These values should be removed or otherwise marked as deprecated or so.

kuniss commented 2 years ago

@mjpcger, I'm going to correct this!

kuniss commented 2 years ago

EVRW_NOCARD is mentioned in endDetection(). EVRW_RELEASE is mentioned at endRemoval(). So, no need to mark them as deprecated. 😄 However, they should be listed in the chapter of extended error code for ErrorEvents.

kuniss commented 1 year ago

Solved with release 1.15.0.