search

JavaPOSWorkingGroup / javapos-contracts

Hosts the interfaces and data types of the UnifiedPOS reference implementation for Java.
Other
8 stars 9 forks source link

Some Enumerated Tag Values For ElectronicValueRW Are Missing #16

Closed mjpcger closed 1 year ago

mjpcger commented 2 years ago

The following constants are missing in ElectronicValueRWConst.java (UPOS version 1.15): EVRW_TAG_TT_COMPLETION EVRW_TAG_TT_PRE_SALES Keep in mind: EVRW_TAG_TT_PRE_SALES is specified as EVRW_TAG_TTPRE-SALES within UPOS specification, however, a '-' cannot be part of a constant and should be replaced by ''.

kuniss commented 2 years ago

The '-' issue has been filed into the UnifiedPOS task tracker as UPOS1151-17 issue and will be corrected for UnifiedPOS 1.16.

kuniss commented 1 year ago

@mjpcger, seems we forgot these 2 constants too...

kuniss commented 1 year ago

We should use the same values as defined at https://github.com/kunif/OPOS-CCO/blob/cc11716c2cd0c367e84945dde3a3ad0d90d48360/Common/Opos/OposEvrw.h#L247 and https://github.com/kunif/OPOS-CCO/blob/cc11716c2cd0c367e84945dde3a3ad0d90d48360/Common/Opos/OposEvrw.h#L248

kuniss commented 1 year ago

Solved with release 1.15.1.