JavaPOSWorkingGroup / javapos-contracts

Hosts the interfaces and data types of the UnifiedPOS reference implementation for Java.
Other
8 stars 9 forks source link

Missing constant for Scale #7

Closed mjpcger closed 2 years ago

mjpcger commented 4 years ago

Constant SCAL_SUE_WEIGHT_UNDERWEIGHT missing. This limits service implementors, making it impossible to signal underweight situation to application.

kuniss commented 4 years ago

Code and UnifiedPOS specification review showed: SCAL_SUE_WEIGHT_UNDERWEIGHT is lacking in ScaleConst.java but defined in the UnifiedPOS specification for Scale's StatusUpdateEvent since UnifiedPOS release 1.14. So it needs to be added as constant.

Note: This is also not defined in OPOS' OposScal.h and in also not in Microsoft's POS for .NET implementation ! The UnifedPOS 1.14 specification is lacking the "Updated in Release 1.14" tag at Scale's StatusUpdateEvent chapter. Maybe therefore, it was not considered, neither in the JavaPOS nor in the OPOS reference and POS for .NET implementations.

Good catch @mjpcger !

kuniss commented 2 years ago

Solved with release 1.14.4.