search

JavadocMD / simplelatlng

A simple, lightweight library for common latitude and longitude calculation needs in Java.
90 stars 20 forks source link

Fixing github issues 9 and 10 #13

Closed attilapalfi92 closed 2 years ago

attilapalfi92 commented 2 years ago
JavadocMD commented 2 years ago

Just a note to say I greatly appreciate the pull request. (Despite its surprise closing.) I've begun the process of modernizing this repository in a number of ways, and I'll include the junit update and an improved hash function.

I found your fix rounding the double-to-long conversions resulted in a number of broken test cases, and I worry might alter expected functionality. However I have a theory that rounding in more limited contexts might be warranted, for example when doing radians-to-degrees math for comparison against the internal fixed-width representation.

Long story short, I am working on a version update to address the spirit of this pull request. Thank you for the inspirational nudge. :slightly_smiling_face: