Javanaise / mrboom-libretro

Mr.Boom is an 8 player Bomberman clone for RetroArch/Libretro
http://mrboom.mumblecore.org
MIT License
204 stars 61 forks source link

Immediately crash dumps when starting core if logging is set to 1 (Info) or below #123

Closed vaguerant closed 1 year ago

vaguerant commented 1 year ago

Running libretro/RetroArch@4f8e3fa and mrboom-libretro 089b91d.

The core itself starts up (i.e. the RetroArch menu), but selecting Start Core crashes the console as below:

DSI exception screen

Disabling logging via Settings > Logging from the RetroArch menu prevents this crash from occurring.

frranck commented 1 year ago

Hello, maybe some empty value there https://github.com/Javanaise/mrboom-libretro/blob/master/libretro/retro.cpp#L123

frranck commented 1 year ago

Could you please update and check if it still fails with logs?

vaguerant commented 1 year ago

Updated to c10355e, sorry to report that the same issue still occurs.

EDIT: Doing a bit more testing, the issue only occurs when Core Logging Level is set to 1 (Info) or lower. 2 (Warning) and 3 (Error) do not crash.

EDIT2: Now that I know that, I can reproduce this on Windows PC as well, it's not Wii U-specific.

The console window prints the following before the emulator exits:

[libretro INFO] retro_variable (SYSTEM)    { '-¿E4∙⌂', '(null)' }
[libretro INFO] retro_variable (SYSTEM)    { 'H)─☼)┤$`@', '' }
LibretroAdmin commented 1 year ago

Does this happen with any core when logging is enabled / set to Level 1 or only with this core?

vaguerant commented 1 year ago

Only this core in my testing. I tested other "normal" cores like pcsx-reARMed as well as contentless cores like VICE x64 and 2048 which run via Start Core. None of the other cores have any issue.

Apaczer commented 1 year ago

Yes I can confirm it SEGFAULTs when you run from retroarch -v -L mrboom_libretro.so cmd, but without verbose it runs ok.

frranck commented 1 year ago

seems this is fixing it https://github.com/Javanaise/mrboom-libretro/commit/20244a75910802b22690407750189f837682c68e

Apaczer commented 1 year ago

seems this is fixing it https://github.com/Javanaise/mrboom-libretro/commit/20244a75910802b22690407750189f837682c68e

It does! Be it logging from RA menu or cmd line there is no crash. GJ :+1: