Javernaut / ffmpeg-android-maker

Contains a script that assembles FFmpeg library for Android
MIT License
587 stars 172 forks source link

linux invalid variable name #74

Open zhubinsheng opened 1 year ago

zhubinsheng commented 1 year ago

COMPONENT_SOURCES_DIR_VARIABLE=SOURCESDIR${COMPONENT} if [[ -z "${!COMPONENT_SOURCES_DIR_VARIABLE}" ]]; then export SOURCESDIR${COMPONENT}=${SOURCE_DIR_FOR_COMPONENT} fi

zhubinsheng commented 1 year ago

i can not compile with fdk-aac

Javernaut commented 1 year ago

Can't see any relevant details and a meaningful problem description. And most importantly - the politeness. Try again.

zhubinsheng commented 1 year ago

sorry i am poor English。

zhubinsheng commented 1 year ago

1.i write two sh here, there is fdk-acc, but i can not use this name, image because this "/bin/sh" not support "-"

  1. i do not know how to link lib without PKG_CONFIG image
Javernaut commented 1 year ago

Here is a branch where the names of libraries are sanitized in order to export variables like 'fdk_aac' for 'fdk-aac' library. So you should be ok adding a 'libfdk-aac' as the flag and the directory with the exact same name.

As for the pkg-config thing, I didn't succeed in building the library on my brief attempt. If you can build it successfully, please do it on Github Actions, so I see all the logs.