search

Javex / libscep

Implementation of the SCEP protocol in C for both client and server
6 stars 8 forks source link

const declarations #75

Open gknocke opened 9 years ago

gknocke commented 9 years ago

I think some configuration parameters should be declared as constant: sigalg in scep_configuration for example: currently, sigalg = EVP_get_digestbyname(md) raises a warning since its return type is declared as static. The same holds for encalg = EVP_get_cipherbyname(alg)

what do you think?

Javex commented 9 years ago

Yeah if it raises a warning, it'd probably not be such a bad idea. However, I recommend first getting up to speed on the correct handlng of const stuff. I mean we don't want to declare something const that we maybe change. For example, on the configuration, you actually want to change it. The alternative would be casting the const away.