Closed Jewelots closed 2 years ago
JavidPack
commented
2 years ago This is quite impressive.
On my discord we've been discussing how the new version should probably behave like the bestiary, marking completion on the world rather than on each individual player. I'm not sure when I'll be able to work on this more, but if you have any more thoughts feel free to discuss them.
Jewelots
commented
2 years ago Ooh, that's probably the better way to go about it, yeah. I'm not playing online nor have people to help test, so I'm likely not the best person to implement it though.
It does seem to be working as intended so far through my playthrough, which is nice. I had one crash that happened after I disabled a mod and it attempted to save tag data about the unloaded item (fixed above); and often the buttons on the top randomly don't visually render their icons correctly (unsure why, since they're going through the TextureAssets system, such as TextureAssets.Item[ItemID.Book], and then is Waited on by the ResizeImage call, so theoretically they should be loaded); but other than that it's all worked as intended.
I probably won't touch it too much more in terms of adding functionaity, as I have other projects/hobbies I'd rather spend time on, but hopefully someone else is willing to use this as a base at some point.
Other features I'd probably recommend are:
Hi! I've been getting into modded playthroughs lately and the idea of this mod sounded like something I really wanted, so I put in some work to fix it up for 1.4. This is a preliminary pull request -- it seems to work as intended but there might be other issues that crop up with testing.
The port work involved largely taking your new UIElements code from RecipeBrowser (with modifications to keep supported/required features that ItemChecklist had previously, like Sort badges) along with other general 1.3 -> 1.4 API changes.
I also converted the panel from a thin side panel to a draggable panel similar to Recipe Browser itself.
It seems to all function correctly from some basic testing, though as mentioned earlier, I'll be playing through a playthrough with various modpacks and I'll update this if anything goes wrong.
Current known issues:
I don't neccesarily think it's Shippable yet, but it's certainly a good base if you want to work on it yourself. Feel free to merge it over if you want to, or take bits of it, or whatever! You're free to use anything I've done.
Thanks, Jewel