JavidPack / RecipeBrowser

RecipeBrowser mod for tModLoader
https://forums.terraria.org/index.php?threads/recipe-browser.62462/
79 stars 49 forks source link

calamity integration (True Melee) #139

Closed AvandorPrime closed 5 months ago

AvandorPrime commented 5 months ago

Changes:

Note:

Using the string representation of Item.Type isn't ideal (eg "CalamityMod.TrueMeleeDamageClass"), both for True melee and whips. In the case of whips I don't believe these exist as an enum field (if it did we would then be able to catch if it ever changed on tmodloader's side), and in the case of calamity it would be impossible to do anyway without adding that mod as a dependency. I can understand if you don't want to add code that could potentially silently break on an update.

If that is the case, I would have to try publishing this change into a standalone compatibility mod between RecipeBrowser and Calamity.

Pictures of the changes follow:

image image image image

AvandorPrime commented 5 months ago

The issue is resolved as won't fix, see comments there for details.