JavidPack / RecipeBrowser

RecipeBrowser mod for tModLoader
https://forums.terraria.org/index.php?threads/recipe-browser.62462/
80 stars 51 forks source link

v8.1 Causes Lag/New Crafting Tree feature not working #46

Open vizthex123 opened 5 years ago

vizthex123 commented 5 years ago

I'm sure this isn't anything new, but I did want to submit my own report.

My game doesn't start lagging til about an hour in, but if I downgrade the version it works fine.

I'd say it's the new crafting tree feature (which I do love, but sadly isn't working)

In addition to that, the new feature doesn't work. I tried to look up the recipe tree for the Ankh Shield and it doesn't show anything. Would be nice if I could at least see the items I need since it's a lot easier to see the mobs it drops from all in one place.

JavidPack commented 5 years ago

As long as you don't have the pre calculate box checked this shouldn't affect anything while not in use.

It only shows you paths that are possible given the enemies killed in the world and the checkboxes you have selected. If you can't currently craft an item, it won't show a path since you can't get it yet.

moll commented 5 years ago

Hey, I'm not sure if @vizthex123 and my problems are similar, but I'm seeing a ~500ms freeze on clicking any recipe with Recipe Browser v0.8.4. I haven't played Terraria in a while, but I don't recall it freezing the entire game for that long in the v0.1–v0.5 days. Is that freeze to be expected or am I the only one? This on a Linux build of Terraria. Thanks in advance!

moll commented 5 years ago

Seems to be that the 500ms lag is related to having selecting "Nearby Chests" in the Recipe tab. Clicking on a shown recipe to see its required objects probably doesn't warrant a recalculation of nearby chests, if that's what truly takes half a second. :)

While on the topic of radio buttons, I'd say they seem backwards — a darkened circled usually marks a selected radio button, but in Recipe Browser it seems to be an all-white button that's the selected one and one with a dark inner circle the unselected.

Standard radio button: Radio_button

Recipe Browser: Screenshot from 2019-11-12 17-02-34

JavidPack commented 5 years ago

The radio button icons are the same that Terraria uses in the settings menus, it's a hollow circle when off and then filled in with white when on. It kinda looks like the off state is filled with black, but it's just empty. I don't want to go opposite of Terraria.