Javier-DarthPalpatine / firefox-hide-caption-titlebar-plus

Automatically exported from code.google.com/p/firefox-hide-caption-titlebar-plus
22 stars 0 forks source link

[DONE] [Feature request] Make the underlying black spot in the top right corner optional #126

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Hi, 
I really like the addon for its features, but not so much for its appearance. 
There is black spot under the minimize/maximize/close buttons.

It is displayed only in maximized or fullscreen window. But not in restored 
window. I guess it is useful in glass design, but I am using Personas skin and 
it's are very disturbing. 

Is there any change to disable it...
...right now, e.g. manually?
...in next version thru settings?
...automatically according to a skin user use (glass vs persona)?

Details:
Windows 7 Professional
Firefox 4.0 Czech
Hide Caption Titlebar Plus 2.1.6

(Screenshots attached)

Original issue reported on code.google.com by v.ovca...@gmail.com on 27 Mar 2011 at 6:57

Attachments:

GoogleCodeExporter commented 9 years ago
I have found a quick fix. Not sure if it doesn't brake something else, but it 
seems ok for now. For Hide Caption Titlebar Plus 2.1.6 do this:

1) Find and open this file in your favorite editor
<profile>\extensions\hidecaptionplus-dp@dummy.addons.mozilla.org.xpi\chrome\skin
_fx4\aero\style.css

2) Delete or just comment this block of code (lines 32-45):
/*
#main-window:not([hcp_fx4_titlebar_visible="true"])[hc-MaxFull="true"]     
#titlebar-buttonbox{
        display: -moz-box !important;
        -moz-appearance: none !important;
        position: fixed !important;
        z-index: -2 !important;

        right: -11px !important; top: -6px !important;
        box-shadow: -7px 4px 3px rgba(20,20,20,1);
        background-color:        rgba(20,20,20,1);

        width: 117px; height: 25px;
        border-radius: 10px 0 0 10px;
        border: 0px;
} */

Original comment by v.ovca...@gmail.com on 27 Mar 2011 at 8:47

GoogleCodeExporter commented 9 years ago
Have the same problem even in glass interface, I would like to make it smaller, 
and obviously I need to edit this part of the code but 

In step "Find and open this file in your favorite editor
<profile>\extensions\hidecaptionplus-dp@dummy.addons.mozilla.org.xpi\chrome\skin
_fx4\aero\style.css"

how did you open .xpi file as a folder ? for me it's just an unopenable file

Original comment by kkir...@gmail.com on 2 Apr 2011 at 1:08

GoogleCodeExporter commented 9 years ago
It's no big deal. *.xpi (pronounce zippy) files are regular *.zip files. So 
rename .xpi to .zip. Unpack .zip file, change the file and zip it again. Rename 
back to xpi and you are done. You can use total commander (or other file 
manager) to edit files in zip archives in more convenient fashion. 

I have attached latest stable version 2.1.6 with the editing already applied. 

Original comment by v.ovca...@gmail.com on 3 Apr 2011 at 5:42

Attachments:

GoogleCodeExporter commented 9 years ago
thank you, friend. I applied my changes and also tried your version, but I get 
the same problem and probably the reason that box was there.  These are the old 
titlebar buttons which are not active. Do you have the same problem ? Any ideas 
how to remove them or at least make them active ?

Original comment by kkir...@gmail.com on 4 Apr 2011 at 1:32

Attachments:

GoogleCodeExporter commented 9 years ago
I don't have this problem. Try this:

1) Change your settings to this: http://cl.ly/3l073C1r180z3r0Y471x
It should remove min/max/close buttons of both - windows and hide caption 
addon. In next step you can read how to get these buttons back, hopefully 
without the problem you are experiencing. 

2) To get nice and static min/max/close buttons back do this:

a) open dialog "Customize toolbars". If you dont know how look here: 
https://support.mozilla.com/en-US/kb/how-do-i-customize-toolbars?redirectlocale=
en-US&redirectslug=How+to+customize+the+toolbar

b) in this dialog you can find something like "[hcp] Min, Max, Close buttons". 
Drag and drop this element in your right top corner. Click ok, and you should 
be done.

If this does not help post screenshots of your Hide caption settings. I try 
reproduce this on my win 7 machine. 

Original comment by v.ovca...@gmail.com on 4 Apr 2011 at 2:36

GoogleCodeExporter commented 9 years ago
I've tried that, doesn't remove those system buttons. Probably that's because I 
used to have Personal Titlebar installed before, after removing it's 
functionality still was there so it's probably a conflict between these 2 
addons. I just turned hide titlebar off and I'm using personal titlebar instead 
and actually I like it better, I got a lot thinner top panel which saves some 
vertical space. Now the only problem seems that big ugly firefox button, in FF 
3.6 I used a hide menubar addon which used to add nice small and round button 
but it doesn't work with FF 4 so I really need a way to change that thing. Any 
help would be appreciated. Thanks again mate. 

Original comment by kkir...@gmail.com on 4 Apr 2011 at 4:36

GoogleCodeExporter commented 9 years ago
Thats a pity it didnt worked. I think you can still go with Hide Caption 
Titlebar, if you have time and mood to create new firefox profile - the current 
one seems broken to me. 

- Hide Menubar does supports FF4 - 
https://addons.mozilla.org/en-us/firefox/addon/hidemenubar/
- Also Movable Firefox Button seems nice - 
https://addons.mozilla.org/en-us/firefox/addon/movable-firefox-button/
- Hide caption titlebar plus can do this too. 

---
Just for your inspiration this is how my firefox looks like 
http://cl.ly/0n1l213r441o0Y2B0Q1L

Pros
 - a lot bigger visible/website area
 - small and easy accessible orange firefox button
 - standard firefox menu accessible after mouse-roll-over orange firefox button and with alt button
 - tree style tabs are real game changer
 - you can easily add bookmarks bar if you prefer it
 - no bugs (so far)
 - looks good in fullscreen/maximized/restored window

Cons 
 - none :-)

Original comment by v.ovca...@gmail.com on 5 Apr 2011 at 8:38

GoogleCodeExporter commented 9 years ago
Thank you for the Movable Firefox Button I loved it. My firefox looks pretty 
close to yours the only major difference are tree style tabs, I just can't get 
used to them :) thank you for all your help, now I'm fully satisfied with the 
way my FF looks. 

Original comment by kkir...@gmail.com on 5 Apr 2011 at 12:47

GoogleCodeExporter commented 9 years ago
That's great! Happy to help. 

Original comment by v.ovca...@gmail.com on 5 Apr 2011 at 6:57

GoogleCodeExporter commented 9 years ago
I have the same problem .... described in this forum topic:
https://forums.mozilla.org/addons/viewtopic.php?f=30&t=3205

Had to disable the add-on :(

The black background is very unsightly with Personas.

Original comment by 4rum...@gmail.com on 29 May 2011 at 7:51

Attachments:

GoogleCodeExporter commented 9 years ago
@4rum...
Sorry to hear that. Btw the quick fix I have proposed is working great for two 
months now. No troubles at all so go ahead and hack your Firefox :-)

Original comment by v.ovca...@gmail.com on 30 May 2011 at 1:22

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
@v.ovca,

I think you forget to add that lines 20 ~ 29 of the above-mentioned style.css 
need to be UN-commented, in addition to what you suggest. Specifically 
speaking, the comment marks at line 20 (/*) and line 29 (*/) have to be removed 
becsuse that segment of scripts is actually, as the comment at the previous 
line 19 explains, "workaround: to hide windows buttons!! (in maximized mode 
only)"

The original lines 19 ~ 29 with comment marks are as follows:

  /* workaround: to hide windows buttons!! (in maximized mode only) */
  /*
  #main-window[hc-MaxFull="true"]   toolbar#toolbar-menubar:not(:-moz-lwtheme),
  #main-window[hc-MaxFull="true"]   toolbar#nav-bar:not(:-moz-lwtheme){
    background-color: rgb(207, 219, 236) !important;
    border-top-color: transparent !important;
  }
  #main-window[hc-MaxFull="true"]   toolbar#TabsToolbar[tabsontop="true"]:not(:-moz-lwtheme){
    background-color: rgb(104, 110, 118) !important;
  }
  */

Original comment by d...@edirect168.com on 3 Jun 2011 at 4:52

GoogleCodeExporter commented 9 years ago
@d...@edirect168.com

Hi, 
thanks for your suggestion. I actually did not mentioned about uncommenting 
19~29 because it does not work in non-glass windows (in win7). And because I 
use ff persona I obviously don't use glass windows and the 19~29 workaround 
does not apply to my use case. But it works in glass windows a bit better than 
my workaround on lines 32~45. 

To make it short:

(1) If you are using glass windows uncomment 19 ~ 29. 
    + it is "official" workaround
    + plays little bit better in glass windows
    - does not work for non-glass windows

(2) If you are using non-glass windows (i.e. Firefox Persona) comment 32 ~ 45. 
    + works on both: glass and non-glass windows.
    - though it works great for months it is rather quick fix without deep insight

Also from my brief testing performing both (1) and (2) is pointless.

---
Does this comply with your experience, d...@edirect168.com?

Original comment by v.ovca...@gmail.com on 11 Jun 2011 at 12:44

GoogleCodeExporter commented 9 years ago
@v.ovca...@gmail.com:

I use Firefox 4.0.1 on Windows 7 x64. The "Enable desktop composition" option 
under the "Visual Effects" tab in the "Performance Options" dialog is selected, 
but "Enable transparent glass" is not.

If I only comment out line 32~45, the black spot still shows. I also have to 
un-comment line 19~29 to avoid that black spot. (My programming knowledge is 
almost zero, but I managed to figure out).

As a test, I've just turned on "Enable transparent glass" and restarted 
Firefox. The black spot still does not show.

Original comment by d...@edirect168.com on 12 Jun 2011 at 1:52

GoogleCodeExporter commented 9 years ago
@d...@edirect168.com

Ah I see. Our test cases are bit different. I have glass windows enabled 
globally, but my firefox is using ff Persona skin which makes ff windows 
non-glass. 

Well I believe you can you use both workarounds, whatever works for you. Thx 
for pointing that out.

Original comment by v.ovca...@gmail.com on 12 Jun 2011 at 5:53

GoogleCodeExporter commented 9 years ago
It's DONE in last version 2.3.0! 

There's new options for hiding system-buttons in Aero-glass mode. I'm expecting 
to upload more improvements in other areas by tomorrow (In Development/Beta 
channel)

(This is pretty the same as Issue 90)

Enjoy!

Original comment by redlibr...@gmail.com on 4 Jul 2011 at 5:37