Javier-DarthPalpatine / firefox-hide-caption-titlebar-plus

Automatically exported from code.google.com/p/firefox-hide-caption-titlebar-plus
22 stars 0 forks source link

[Un-maximized] - White line at top of screen. #244

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
Here's my settings: http://screencast.com/t/mFSNUTQOBy
http://screencast.com/t/mFSNUTQOBy

What is the expected output?

No white line at top of screen, see shot: http://screencast.com/t/EuqQ9KbB

What do you see instead?

A white line at top of screen.

What version of "Hide Caption Titlebar Plus" addon are you using?

2.8.2

What version of Firefox?

29.01

On what operating system?

Windows 8.1

- If there are visual issues, please provide also screenshot/s (preferred
uploaded here instead of external link)

Original issue reported on code.google.com by math...@gmail.com on 12 May 2014 at 6:36

GoogleCodeExporter commented 9 years ago
I was coming here to report this as well.

Original comment by PimpUigi on 14 May 2014 at 2:00

GoogleCodeExporter commented 9 years ago
Hi!

1) About that line I see in the shot: is that from a UN-maximized (restored) 
window right?  If so, there's always a soft white line at window borders (@ all 
borders if 'System Borders' are disabled, witch IMHO looks nicer in Win8).  
Maybe I can add a configuration entry for that. 
In maximized windows -of course- should NOT be any line, Is that correct in 
this case?

2) If that line IS in a maximized window: I couldn't reproduce that, but I see 
you have other addons that seems like 'Classic Restorer' (I've tested it too) 
that can interfere in some areas.

Tks!

Original comment by redlibr...@gmail.com on 14 May 2014 at 8:13

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Thanks for the reply!

You are def right that it is un-maxed windows only, in maxed windows it looks 
fine.  I'm not sure I 100% follow you with #1, is the line a function of the 
addon or something inherent to windows?  If it is a function of the addon do 
you mean there is a setting that could disable it?

Thanks again for your help, I might just try and remove it with a user style 
thingy.

Original comment by math...@gmail.com on 14 May 2014 at 8:33

GoogleCodeExporter commented 9 years ago
You're Welcome!

Yes, The window border lines are part of the addon and can be removed with a 
style. (try with 'System Borders' disabled and see the look in un-maximized)

Original comment by redlibr...@gmail.com on 15 May 2014 at 5:07

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Here's the code I'm currently using for Stylish.
This is with the classic min-max-close buttons.

This will fix the issue for both Windows 8 (top 3/4ths) and Windows 7 (bottom 
1/4th).

@namespace url(http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul);
@-moz-document url(chrome://browser/content/browser.xul) {

    #hcp-caption-box {
        margin-top: -3px !important;
    }

    #hcp-title-box-label {
        visibility: collapse !important;
    }

    #hctp-controls-top-fixed {
        margin-top: 1px !important;
        margin-right: -2px !important;
    }

@media all and (-moz-windows-theme:aero) {

    #hctp-controls-top-fixed {
        margin-top: -3px !important;
        margin-right: -2px !important;
    }
}

Original comment by PimpUigi on 10 Jun 2014 at 11:49

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks a bunch for this, fixed it perfectly for me, maybe this could be 
included in the main release?

Original comment by math...@gmail.com on 8 Sep 2014 at 4:44

GoogleCodeExporter commented 9 years ago
You have to add this in to the top half for Firefox 32.

    #browser-panel {
        border: none !important;
    }

Original comment by PimpUigi on 8 Sep 2014 at 5:02