search

Javier-DarthPalpatine / firefox-hide-caption-titlebar-plus

Automatically exported from code.google.com/p/firefox-hide-caption-titlebar-plus
22 stars 0 forks source link

[FIXED on ver 2.9.8 and 2.10.1] [DPI > 1.1] Smaller toolbar options now all make buttons huge #289

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
Enable any of the "Smaller Toolbars and Buttons" options

What is the expected output?
The toolbar and buttons will get smaller.

What do you see instead?
The buttons become larger and the icons within fill the entire button. 

What version of "Hide Caption Titlebar Plus" addon are you using?
2.9.7

What version of Firefox?
40.0

On what operating system?
Windows 7 Home Premium SP1 64-bit

- Please provide any additional information below.
You may also need to enable 120 DPI mode (125%) on Windows, as this will change 
the initial size of the toolbars. On Windows 7, that's under Control Panel > 
Display. 

- Please provide your system info by using this url (with installed hct+):
Name of the browser (appName)   Netscape
Name of the browser vendor (vendor) 
Code name of the browser (appCodeName)  Mozilla
Engine of the browser (product) Gecko
Build number of the browser engine (productSub) 20100101
Version and platform of the browser (appVersion)    5.0 (Windows)
Version of the browser given by the vendor (vendorSub)  
Build identifier of the browser (buildID)   20150812163655
User-agent request header (userAgent)   Mozilla/5.0 (Windows NT 6.1; WOW64; 
rv:40.0) Gecko/20100101 Firefox/40.0
Language of the browser (chrome-locale) en-US
Language preference in the browser (useragent-locale)   en-US
Cookies are enabled (cookieEnabled) true
Operating system (platform) Win32
Information about the OS and CPU (oscpu)    Windows NT 6.1; WOW64
System is online (onLine)   true

- If there are visual issues, please provide also screenshot/s 
I have attached three images. While they all use the Dark Green Persona, THE 
RESULTS ARE THE SAME WHEN I TURN THE THEME OFF.

The first shows all the modes on 0.9.7. Notice how they are all the same height 
but the buttons and icons are much bigger?

The second shows how it worked on 0.9.6. When enabled, the height reduces from 
52px to 40px. Only "Smaller buttons" has a problem with the icons getting 
larger.

The third shows what I think is optimal, based on what you appear to be able to 
actually do. The changes I made were to keep the back button icon the same size 
(since the button itself doesn't shrink), making the left margin on both the 
last two options the same, and renaming those last two options to reflect what 
they actually do.

Also, I lament that I forgot to give show the forward button. But as it remains 
the same in all modes in both versions, I don't think it matters.

Original issue reported on code.google.com by terrell....@gmail.com on 18 Aug 2015 at 8:19

Attachments:

GoogleCodeExporter commented 9 years ago 
similar situation. 

win8.1 dell v8pro tablet. firefox 40.0.2, addon 2.9.7

the Back button and New button are bigger than before.

Original comment by mail.xu2...@gmail.com on 18 Aug 2015 at 2:33

GoogleCodeExporter commented 9 years ago 
I found a pref that changes the DPI in Firefox only, making it easier to test: 
layout.css.devPixelsPerPx. On Windows, setting it above 1.1 (so 1.11+) makes 
makes the bar go huge.  The problem does not occur on Linux, no matter what the 
setting of the above pref.

Original comment by terrell....@gmail.com on 19 Aug 2015 at 4:51

GoogleCodeExporter commented 9 years ago 

I'm on it. Will be released soon!
Tks for these reports & data!

Original comment by redlibr...@gmail.com on 19 Aug 2015 at 6:57

Javier-DarthPalpatine commented 9 years ago

FIXED.